Bug 26640

Summary: JSON.stringify needs to special case Boolean objects
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: JavaScriptCoreAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 26249    
Attachments:
Description Flags
Special case Boolean ap: review+

Oliver Hunt
Reported 2009-06-22 22:08:09 PDT
Boolean is special cased alongside Number and String objects now (http://wiki.ecmascript.org/lib/exe/fetch.php?id=es3.1%3Aes3.1_proposal_working_draft&cache=cache&media=es3.1:es5_candidate_errata_june_17.pdf)
Attachments
Special case Boolean (8.80 KB, patch)
2009-06-22 22:34 PDT, Oliver Hunt 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2009-06-22 22:34:58 PDT
Created attachment 31705 [details] Special case Boolean
Alexey Proskuryakov
Comment 2 2009-06-22 22:42:31 PDT
Comment on attachment 31705 [details] Special case Boolean r=me. LayoutTests/ChangeLog should mention that you added other primitive tests, not just booleans.
Oliver Hunt
Comment 3 2009-06-22 22:45:30 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/runtime/JSONObject.cpp M LayoutTests/ChangeLog M LayoutTests/fast/js/JSON-stringify-expected.txt M LayoutTests/fast/js/resources/JSON-stringify.js M LayoutTests/fast/js/resources/json2-es5-compat.js Committed r44974
Note You need to log in before you can comment on or make changes to this bug.