Bug 266384

Summary:

AX: aria-labeledby should be ignored for browser interop reasons.

Product:

WebKit

Reporter:

Andres Gonzalez <andresg_22>

Component:

Accessibility

Assignee:

Andres Gonzalez <andresg_22>

Status:

NEW

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cdumez, cfleizach, changseok, clopez, cmarcelo, dmazzoni, esprehn+autocc, ews-watchlist, gyuyoung.kim, jcraig, kangil.han, samuel_white, tyler_w, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://github.com/web-platform-tests/wpt/pull/43678

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	tyler_w: review-, ews-feeder: commit-queue-

Andres Gonzalez

Reported 2023-12-13 18:05:12 PST

Only aria-labelledby should be used instead.

Attachments
Patch (10.67 KB, patch) 2023-12-13 18:16 PST, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (12.70 KB, patch) 2023-12-14 07:17 PST, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (12.02 KB, patch) 2023-12-14 07:49 PST, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (14.20 KB, patch) 2023-12-14 14:01 PST, Andres Gonzalez	no flags	Details Formatted Diff Diff
Patch (14.88 KB, patch) 2023-12-14 16:53 PST, Andres Gonzalez	tyler_w: review- ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-12-13 18:05:20 PST

<rdar://problem/119640762>

Andres Gonzalez

Comment 2 2023-12-13 18:16:26 PST

Created attachment 469031 [details] Patch

Andres Gonzalez

Comment 3 2023-12-14 07:17:47 PST

Created attachment 469039 [details] Patch

EWS Watchlist

Comment 4 2023-12-14 07:21:04 PST

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Andres Gonzalez

Comment 5 2023-12-14 07:49:23 PST

Created attachment 469040 [details] Patch

Andres Gonzalez

Comment 6 2023-12-14 14:01:45 PST

Created attachment 469046 [details] Patch

Andres Gonzalez

Comment 7 2023-12-14 16:53:15 PST

Created attachment 469051 [details] Patch

Tyler Wilcock

Comment 8 2023-12-15 09:50:48 PST

Comment on attachment 469051 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=469051&action=review > LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt:6 > +usingLabel.title: [AXTitle: ] Why is this testcase affected by removing aria-labeledby? It was just using its button innner-text with an aria-label, no aria-labelledby or labeledby as far as I can tell. > LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt:8 > +usingLabelledby.title: [AXTitle: ] As the correct-spelling version, shouldn't this still have a title?

Andres Gonzalez

Comment 9 2023-12-15 10:07:02 PST

(In reply to Tyler Wilcock from comment #8) > Comment on attachment 469051 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=469051&action=review > > > LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt:6 > > +usingLabel.title: [AXTitle: ] > > Why is this testcase affected by removing aria-labeledby? It was just using > its button innner-text with an aria-label, no aria-labelledby or labeledby > as far as I can tell. > > > LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt:8 > > +usingLabelledby.title: [AXTitle: ] > > As the correct-spelling version, shouldn't this still have a title? The accessibility/*-expected.txt wasn't being used because there was one for platform/Mac and one for platform/glib. So what I did was to remove the one from platform/Mac and move it to accessibility, as we do with most other tests, i.e., the Mac expectation file is in the accessibility dir and other platforms if differ are int heir corresponding platform/ dirs. So if you compare the new accessibility/*-expected.txt with the deleted platform/Mac one, you can confirm that the only change is the removal of the labeledby lines. Thanks for being alert about these changes.

Tyler Wilcock

Comment 10 2023-12-15 10:09:13 PST

(In reply to Andres Gonzalez from comment #9) > (In reply to Tyler Wilcock from comment #8) > > Comment on attachment 469051 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=469051&action=review > > > > > LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt:6 > > > +usingLabel.title: [AXTitle: ] > > > > Why is this testcase affected by removing aria-labeledby? It was just using > > its button innner-text with an aria-label, no aria-labelledby or labeledby > > as far as I can tell. > > > > > LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt:8 > > > +usingLabelledby.title: [AXTitle: ] > > > > As the correct-spelling version, shouldn't this still have a title? > > The accessibility/*-expected.txt wasn't being used because there was one for > platform/Mac and one for platform/glib. So what I did was to remove the one > from platform/Mac and move it to accessibility, as we do with most other > tests, i.e., the Mac expectation file is in the accessibility dir and other > platforms if differ are int heir corresponding platform/ dirs. So if you > compare the new accessibility/*-expected.txt with the deleted platform/Mac > one, you can confirm that the only change is the removal of the labeledby > lines. Thanks for being alert about these changes. Oh right, should've noticed that, thanks!

Tyler Wilcock

Comment 11 2023-12-15 13:12:59 PST

Comment on attachment 469051 [details] Patch Changing to r- as the misspelling is used by too many sites to remove for now.

James Craig

Comment 12 2023-12-15 14:14:36 PST

More info on that here: - https://github.com/w3c/aria/issues/2093

Note You need to log in before you can comment on or make changes to this bug.