Bug 266359
| Summary: | [ews] revert-pull-request-changes step does not appear to delete the build directory | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, ap, emw, jbedard, ryanhaddad, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=235825 | ||
Elliott Williams
In builds like https://ews-build.webkit.org/#/builders/14/builds/31777, I see it running `git clean -f -d` only, which is not enough to delete the WebKitBuild directory, since it's gitignore'd.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/119947440>
Aakash Jain
In patch workflow we run the step UnApplyPatch which runs Tools/Scripts/clean-webkit. Whereas in PR workflow we run RevertPullRequestChanges step which run this git clean command.
I wonder in PR workflow, we un-intentionally stopped doing proper clean build.
Note that the same UnApplyPatch wasn't used in PR workflow for reason mentioned in https://bugs.webkit.org/show_bug.cgi?id=235825#c0 , but maybe we can have both UnApplyPatch as well as RevertPullRequestChanges step in PR workflow.
Aakash Jain
> both UnApplyPatch as well as RevertPullRequestChanges
I mean both CleanWorkingDirectory and RevertPullRequestChanges steps.
Jonathan Bedard
I didn't realize we intended to delete the WebKitBuild directory, in this circumstance.
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/28412
EWS
Committed 278689@main (55a78ab59e0a): <https://commits.webkit.org/278689@main>
Reviewed commits have been landed. Closing PR #28412 and removing active labels.