| Summary: | [IFC][Ruby] Incorrect preferred width computation when <ruby> is present | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
zalan
2023-12-13 10:40:14 PST
Created attachment 469019 [details]
Patch
Comment on attachment 469019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=469019&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:4704 > + rubyBaseMinimumMaximumWidthStack.append(std::make_pair(inlineMin, inlineMax)); I think you can alternatively just say std::pair { inlineMin, inlineMax }, make_pair is not necessary anymore. Created attachment 469021 [details]
Patch
Created attachment 469022 [details]
Patch
Created attachment 469023 [details]
[fast-cq]Patch
Created attachment 469027 [details]
[fast-cq]Patch
Committed 272011@main (fcb3a49fe8cd): <https://commits.webkit.org/272011@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 469027 [details]. |