Bug 266331 – REGRESSION(271819@main): Build fails due to undeclared identifier InlineCallFrameMalloc

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Adrian Perez]

% NUMBER_OF_PROCESSORS=33 ./Tools/Scripts/build-webkit --wpe --no-unified-builds
Building flatpak based environment
+  cmake --build /app/webkit/WebKitBuild/WPE/Release --config Release -- -j33
[1/1/2|0.0/s|  0%] Re-checking globbed directories...
[33/38/8065|0.3/s|  0%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/bytecode/InlineCallFrameSet.cpp.o
FAILED: Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/bytecode/InlineCallFrameSet.cpp.o 
/usr/bin/ccache /usr/lib/sdk/llvm16/bin/clang++ -DBUILDING_JavaScriptCore -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WPE__=1 -DBWRAP_EXECUTABLE=\"/usr/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/usr/bin/xdg-dbus-proxy\" -DGETTEXT_PACKAGE=\"WPE\" -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DPAS_BMALLOC=1 -DPKGLIBDIR=\"/usr/local/lib/wpe-webkit-2.0\" -DSTATICALLY_LINKED_WITH_WTF -DSTATICALLY_LINKED_WITH_bmalloc -I/app/webkit/WebKitBuild/WPE/Release/JavaScriptCore/Headers -I/app/webkit/WebKitBuild/WPE/Release -I/app/webkit/Source/JavaScriptCore -I/app/webkit/Source/JavaScriptCore/API -I/app/webkit/Source/JavaScriptCore/assembler -I/app/webkit/Source/JavaScriptCore/b3 -I/app/webkit/Source/JavaScriptCore/b3/air -I/app/webkit/Source/JavaScriptCore/bindings -I/app/webkit/Source/JavaScriptCore/builtins -I/app/webkit/Source/JavaScriptCore/bytecode -I/app/webkit/Source/JavaScriptCore/bytecompiler -I/app/webkit/Source/JavaScriptCore/dfg -I/app/webkit/Source/JavaScriptCore/disassembler -I/app/webkit/Source/JavaScriptCore/disassembler/ARM64 -I/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis -I/app/webkit/Source/JavaScriptCore/domjit -I/app/webkit/Source/JavaScriptCore/ftl -I/app/webkit/Source/JavaScriptCore/fuzzilli -I/app/webkit/Source/JavaScriptCore/heap -I/app/webkit/Source/JavaScriptCore/debugger -I/app/webkit/Source/JavaScriptCore/inspector -I/app/webkit/Source/JavaScriptCore/inspector/agents -I/app/webkit/Source/JavaScriptCore/inspector/augmentable -I/app/webkit/Source/JavaScriptCore/inspector/remote -I/app/webkit/Source/JavaScriptCore/interpreter -I/app/webkit/Source/JavaScriptCore/jit -I/app/webkit/Source/JavaScriptCore/llint -I/app/webkit/Source/JavaScriptCore/parser -I/app/webkit/Source/JavaScriptCore/profiler -I/app/webkit/Source/JavaScriptCore/runtime -I/app/webkit/Source/JavaScriptCore/tools -I/app/webkit/Source/JavaScriptCore/wasm -I/app/webkit/Source/JavaScriptCore/wasm/js -I/app/webkit/Source/JavaScriptCore/yarr -I/app/webkit/WebKitBuild/WPE/Release/JavaScriptCore/DerivedSources -I/app/webkit/WebKitBuild/WPE/Release/JavaScriptCore/DerivedSources/inspector -I/app/webkit/WebKitBuild/WPE/Release/JavaScriptCore/DerivedSources/runtime -I/app/webkit/WebKitBuild/WPE/Release/JavaScriptCore/DerivedSources/yarr -I/app/webkit/Source/JavaScriptCore/API/glib -I/app/webkit/WebKitBuild/WPE/Release/JavaScriptCoreGLib/DerivedSources -I/app/webkit/WebKitBuild/WPE/Release/JavaScriptCoreGLib/DerivedSources/jsc -I/app/webkit/WebKitBuild/WPE/Release/JavaScriptCoreGLib/Headers -I/app/webkit/Source/JavaScriptCore/inspector/remote/glib -I/app/webkit/WebKitBuild/WPE/Release/WTF/Headers -I/app/webkit/WebKitBuild/WPE/Release/bmalloc/Headers -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -pipe -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-parentheses-equality -Qunused-arguments -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare  -fno-strict-aliasing -fno-exceptions -fno-rtti -O3 -DNDEBUG -std=c++20 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -ffp-contract=off -fno-slp-vectorize -Werror -MD -MT Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/bytecode/InlineCallFrameSet.cpp.o -MF Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/bytecode/InlineCallFrameSet.cpp.o.d -o Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/bytecode/InlineCallFrameSet.cpp.o -c /app/webkit/Source/JavaScriptCore/bytecode/InlineCallFrameSet.cpp
In file included from /app/webkit/Source/JavaScriptCore/bytecode/InlineCallFrameSet.cpp:27:
/app/webkit/Source/JavaScriptCore/bytecode/InlineCallFrameSet.h:44:74: error: use of undeclared identifier 'InlineCallFrameMalloc'
    using FrameBag = Bag<InlineCallFrame, RawPtrTraits<InlineCallFrame>, InlineCallFrameMalloc>;
                                                                         ^
/app/webkit/Source/JavaScriptCore/bytecode/InlineCallFrameSet.h:45:13: error: use of undeclared identifier 'FrameBag'
    typedef FrameBag::iterator iterator;
            ^
/app/webkit/Source/JavaScriptCore/bytecode/InlineCallFrameSet.h:50:5: error: unknown type name 'FrameBag'
    FrameBag m_frames;
    ^
%

[Adrian Perez]

It seems that InlineCallFrameMalloc is not defined anywhere, using
“git grep InlineCallFrameMalloc Source/” renders no results (also
no results grepping in the derived sources). Maybe the intention
was to leave out the last parameter of the template and let the C++
compiler pick the Malloc=FastMalloc default instead.

[Adrian Perez]

Pull request: https://github.com/WebKit/WebKit/pull/21727

[EWS]

Committed 271979@main (cfd1072e6014): <https://commits.webkit.org/271979@main>

Reviewed commits have been landed. Closing PR #21727 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/119610848>