Bug 266274
| Summary: | Remove ControlStates::State in favor of ControlStyle::State | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | DOM | Assignee: | Anne van Kesteren <annevk> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 266272, 266281 | ||
| Bug Blocks: | |||
Anne van Kesteren
Unlike RenderTheme::extractControlStyleForRenderer(), RenderTheme::extractControlStatesForRenderer() does not account for shadow host ancestors. The latter also essentially duplicates the exact functionality.
This almost caused a problem for iOS switch controls which happen to use the latter, but they only rely on a state which happens to be shared. Still, that will not last forever so we need to address this.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Anne van Kesteren
Pull request: https://github.com/WebKit/WebKit/pull/21797
EWS
Committed 272106@main (f93441ff7ade): <https://commits.webkit.org/272106@main>
Reviewed commits have been landed. Closing PR #21797 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/119713966>