Bug 26607 – Implement IDL interface for datagrid rows

• Component: Forms
• Status: RESOLVED FIXED

[Dave Hyatt]

Interface for row elements.

[Dave Hyatt]

Created attachment 31650 [details]
Patch

[Sam Weinig]

Comment on attachment 31650 [details]
Patch

> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 44935)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,38 @@
> [phone]  David Hyatt  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        WARNING: NO TEST CASES ADDED OR CHANGED


Some changelogy goodness please.


> +
> +#ifndef HTMLDataGridRowElement_h
> +#define HTMLDataGridRowElement_h
> +
> +#include "HTMLElement.h"
> +
> +namespace WebCore {
> +
> +class HTMLDataGridRowElement : public HTMLElement
> +{

{ should go on the previous line.

> +public:
> +    HTMLDataGridRowElement(const QualifiedName&, Document*);
> +
> +    virtual int tagPriority() const { return 2; } // Same as <option>s.
> +    
> +    bool selected() const;
> +    void setSelected(bool);
> +    
> +    bool focused() const;
> +    void setFocused(bool);
> +};
> +
> +} //namespace

should be // namespace WebCore

> +
> +#endif

We like to add #endif // HTMLDataGridRowElement_h

r=me with these cleanups.

[Dave Hyatt]

Fixed in r44937.