Bug 26600

Summary: StringImpl::copy() no longer copies empty string correctly
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: PlatformAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Critical CC: darin, mbelshe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
proposed fix levin: review+

Alexey Proskuryakov
Reported 2009-06-22 00:54:30 PDT
StringImpl::copy() should not ever return per-thread empty string, because this function's result is for using on other threads. This was broken in <http://trac.webkit.org/changeset/41917> - StringImpl::create() has a special case for empty strings, so calling it is not appropriate.
Attachments
proposed fix (1.63 KB, patch)
2009-06-22 12:11 PDT, Alexey Proskuryakov 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2009-06-22 12:11:52 PDT
Created attachment 31663 [details] proposed fix
Alexey Proskuryakov
Comment 2 2009-06-22 13:14:51 PDT
Committed revision 44952.
Alexey Proskuryakov
Comment 3 2009-06-25 21:27:02 PDT
See <rdar://6964477> and its duplicates.
Note You need to log in before you can comment on or make changes to this bug.