Bug 265891
| Summary: | Remove strange parentElement() code from HitTestResult | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While looking through clean-ups, I came across another potential from Blink's commit:
Blink Commit: https://chromium.googlesource.com/chromium/blink/+/ceea705be631379fd0d012d4f20128ad3e7296ea
"This code doesn't make any sense, why would the parentElement() be in
the document if the node wasn't?
It came from http://src.chromium.org/viewvc/blink?view=revision&revision=23994
7 years ago when the HitTestResult was actually stored in the Event, but
even then it doesn't seem to make sense."
WebKit Source: https://searchfox.org/wubkat/rev/1a7afa1ea1ff078e0856c604cc572aa47d35f2eb/Source/WebCore/rendering/HitTestResult.cpp#796
Just wanted to raise to get input so we can do this clean-up.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/119566622>
Ahmad Saleem
Draft PR - https://github.com/WebKit/WebKit/pull/22003
EWS
Committed 272265@main (ceaf6d34ab11): <https://commits.webkit.org/272265@main>
Reviewed commits have been landed. Closing PR #22003 and removing active labels.