Bug 265729
| Summary: | [offlineasm] Incremental build failure when generator is interrupted | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Elliott Williams
It generators its headers non-atomically, so if the script is interrupted due to a build failure in a parallel task, it leaves a partially-written header. The build system (XCBuild, at least, I didn't try ninja) can't tell that this header is incomplete, so its presence breaks subsequent rebuilds.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/119079705>
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/21217
EWS
Committed 271640@main (97b3a2dd3db7): <https://commits.webkit.org/271640@main>
Reviewed commits have been landed. Closing PR #21217 and removing active labels.