Bug 265719
| Summary: | HTMLDocument::isCaseSensitiveAttribute() misses direction attribute | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | DOM | Assignee: | Anne van Kesteren <annevk> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | annevk, karlcow, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, GoodFirstBug, InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While looking into Blink source and then comparing it WebKit, I noticed that we don't have 'direction' (of HTML Marquee - I know I know) as case sensitive selector. I was not able to find Web-spec reference, so I went to 'Anne' (HTML Champion), if he can help and he did.
Web-Spec: https://html.spec.whatwg.org/#case-sensitivity-of-selectors
WebKit Source: https://github.com/WebKit/WebKit/blob/b10105f3d6b7e01e12f1c141a0aebc023f2324c9/Source/WebCore/html/HTMLDocument.cpp#L184
We need to add direction (&directionAttr,) in alphabetical order.
Failing Test (again thanks to Anne) - data:text/html,<style>marquee[direction=left]{background:lime}</style><marquee%20direction=LEFT>BLAH</marquee>
^ We don't get 'lime' color but Blink does.
Just raising so we can fix it.
@Anne - Thanks for your help as always. Appreciate it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
Probably it would be good to add a WPT test for it too.
Maybe in https://wpt.fyi/results/css/selectors/attribute-selectors/attribute-case/syntax.html
Radar WebKit Bug Importer
<rdar://problem/119432066>
Anne van Kesteren
Pull request: https://github.com/WebKit/WebKit/pull/21966
EWS
Committed 272219@main (629d6a1da6c4): <https://commits.webkit.org/272219@main>
Reviewed commits have been landed. Closing PR #21966 and removing active labels.