Bug 265673

Summary: [scroll-animations] WPT test scroll-animations/css/view-timeline-shorthand.html has incorrect contraction tests
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, graouts, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/43478
Bug Depends on:    
Bug Blocks: 265668    

Antoine Quint
Reported 2023-12-01 09:04:08 PST
There are three tests at the end of the WPT test scroll-animations/css/view-timeline-shorthand.html: ``` test_shorthand_contraction('view-timeline', { 'view-timeline-name': '--a, --b, --c', 'view-timeline-axis': 'inline, inline', 'view-timeline-inset': 'auto, auto', }, ''); test_shorthand_contraction('view-timeline', { 'view-timeline-name': '--a, --b', 'view-timeline-axis': 'inline, inline, inline', 'view-timeline-inset': 'auto, auto, auto', }, ''); test_shorthand_contraction('view-timeline', { 'view-timeline-name': '--a, --b', 'view-timeline-axis': 'inline, inline', 'view-timeline-inset': 'auto, auto, auto', }, ''); ``` These are wrong in the same way that the equivalent `scroll-timeline` shorthand tests were and which got fixed in 271190@main after discussion at https://github.com/web-platform-tests/wpt/issues/43336. Indeed, the computed value should trim the longhands to match the length of `view-timeline-name`.
Attachments
Antoine Quint
Comment 1 2023-12-01 09:07:52 PST
Antoine Quint
Comment 2 2023-12-01 09:41:43 PST
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/43478
EWS
Comment 3 2023-12-01 10:59:02 PST
Committed 271397@main (3ec49d8dfd30): <https://commits.webkit.org/271397@main> Reviewed commits have been landed. Closing PR #21166 and removing active labels.
Radar WebKit Bug Importer
Comment 4 2023-12-01 11:00:17 PST
Note You need to log in before you can comment on or make changes to this bug.