Bug 26558

Summary: [fixup-needed] WINCE needs important date related symbols
Product: WebKit Reporter: Adam Treat <manyoso>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, staikos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 23154    
Attachments:
Description Flags
Rectify
staikos: review+
patch to DateMath.cpp staikos: review+

Adam Treat
Reported 2009-06-19 12:47:32 PDT
Hi, The date functions in DateConstructor and DatePrototype rely upon the symbols 'time' and 'strftime' which are not available under WINCE proper. Rather they are provided by libce.
Attachments
Rectify (2.34 KB, patch)
2009-06-19 12:48 PDT, Adam Treat 		staikos: review+
DetailsFormatted DiffDiff
patch to DateMath.cpp (1.30 KB, patch)
2009-07-30 12:47 PDT, Joe Mason 		staikos: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Treat
Comment 1 2009-06-19 12:48:37 PDT
Created attachment 31560 [details] Rectify
George Staikos
Comment 2 2009-06-19 12:50:27 PDT
Comment on attachment 31560 [details] Rectify We should enhance our strftime to support # later and remove the formatting hack.
Adam Treat
Comment 3 2009-06-19 13:10:40 PDT
Landed with r44866.
Darin Adler
Comment 4 2009-06-19 15:57:47 PDT
Comment on attachment 31560 [details] Rectify Normally we put these kinds of workarounds into header files. For example, this is what MathExtras.h is for. Also, is there really no WinCE system header file to include to get these?
Yong Li
Comment 5 2009-06-22 11:39:29 PDT
(In reply to comment #4) > (From update of attachment 31560 [details] [review]) > Normally we put these kinds of workarounds into header files. For example, this > is what MathExtras.h is for. > > Also, is there really no WinCE system header file to include to get these? > Really no. C runtime on WINCE doesn't contain these functions. This is why we need to provide a WINCE implementation for them.
George Staikos
Comment 6 2009-07-30 12:29:27 PDT
A patch was missed apparently.
Joe Mason
Comment 7 2009-07-30 12:47:59 PDT
Created attachment 33806 [details] patch to DateMath.cpp DateMath.cpp also uses time symbols that have no header file on WinCE
George Staikos
Comment 8 2009-07-30 12:49:46 PDT
Comment on attachment 33806 [details] patch to DateMath.cpp > +#if PLATFORM(WINCE) && ! PLATFORM(QT) Maybe remove that extra space on checkin
Adam Barth
Comment 9 2009-08-02 01:05:37 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/DateMath.cpp Committed r46692 M JavaScriptCore/wtf/DateMath.cpp M JavaScriptCore/ChangeLog r46692 = 63611919366d757b9062c49340f72b14c7a06f32 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46692
Note You need to log in before you can comment on or make changes to this bug.