Bug 265557
| Summary: | Reference being taken to SourceBufferPrivateAVFObjC in destructor | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jean-Yves Avenard [:jya]
In bug 265274, WeakPtr were changed to ThreadSafeWeakPtr meaning that the code now take a RefPtr whenever calling _parent.get() which is in the middle of being destructed [1]
There's no need to check if the _parent is still alive in the invalidate method as parent isn't referenced.
[1] https://searchfox.org/wubkat/rev/c20f54808bd9cd41e49a640e8c20923340e4d14b/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm#138-141
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Jean-Yves Avenard [:jya]
rdar://118957859
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/21085
EWS
Committed 271325@main (0769c4423a3f): <https://commits.webkit.org/271325@main>
Reviewed commits have been landed. Closing PR #21085 and removing active labels.