Bug 26552

Summary: JS bindings for HTMLAudioElement
Product: WebKit Reporter: Kyle Prete <kylep>
Component: PlatformAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
change to V8CustomBinding.h
none
new file necessary
dglazkov: review-
Patch
dglazkov: review-
Patch
dglazkov: review-
Patch
dglazkov: review-
Patch dglazkov: review+

Kyle Prete
Reported 2009-06-19 11:26:50 PDT
WebKit/WebCore/bindings/v8/custom/V8CustomBinding.h needs DECLARE_CALLBACK(HTMLAudioElementConstructor); WebKit/WebCore/bindings/v8/custom/ needs a .cpp file for V8HTMLAudioElementConstructor
Attachments
change to V8CustomBinding.h (23.70 KB, patch)
2009-06-19 11:31 PDT, Kyle Prete 		no flags
DetailsFormatted DiffDiff
new file necessary (2.81 KB, patch)
2009-06-19 11:32 PDT, Kyle Prete 		dglazkov: review-
DetailsFormatted DiffDiff
Patch (3.85 KB, patch)
2009-06-19 11:38 PDT, Kyle Prete 		dglazkov: review-
DetailsFormatted DiffDiff
Patch (3.84 KB, patch)
2009-06-19 11:46 PDT, Kyle Prete 		dglazkov: review-
DetailsFormatted DiffDiff
Patch (4.49 KB, patch)
2009-06-19 11:56 PDT, Kyle Prete 		dglazkov: review-
DetailsFormatted DiffDiff
Patch (4.54 KB, patch)
2009-06-19 14:22 PDT, Kyle Prete 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Kyle Prete
Comment 1 2009-06-19 11:31:59 PDT
Created attachment 31551 [details] change to V8CustomBinding.h
Kyle Prete
Comment 2 2009-06-19 11:32:35 PDT
Created attachment 31552 [details] new file necessary
Dimitri Glazkov (Google)
Comment 3 2009-06-19 11:35:16 PDT
Please read http://webkit.org/coding/contributing.html for guidelines on submitting patches.
Kyle Prete
Comment 4 2009-06-19 11:38:50 PDT
Created attachment 31553 [details] Patch
Dimitri Glazkov (Google)
Comment 5 2009-06-19 11:43:09 PDT
Comment on attachment 31553 [details] Patch Need a ChangeLog entry. > + if (args.Length() > 0) { > + audio->setSrc(toWebCoreString(args[0])); > + } No braces for one-liners.
Kyle Prete
Comment 6 2009-06-19 11:46:23 PDT
Created attachment 31554 [details] Patch
Dimitri Glazkov (Google)
Comment 7 2009-06-19 11:48:33 PDT
Comment on attachment 31554 [details] Patch Don't rush :) Still need a ChangeLog entry.
Kyle Prete
Comment 8 2009-06-19 11:56:28 PDT
Created attachment 31556 [details] Patch My bad. Didn't understand what you meant.
Dimitri Glazkov (Google)
Comment 9 2009-06-19 14:16:19 PDT
Comment on attachment 31556 [details] Patch Sorry, spoke too soon -- need bug URL in ChangeLog.
Kyle Prete
Comment 10 2009-06-19 14:22:54 PDT
Created attachment 31564 [details] Patch
Dimitri Glazkov (Google)
Comment 11 2009-06-19 14:26:24 PDT
Comment on attachment 31564 [details] Patch Beautiful.
David Levin
Comment 12 2009-06-22 13:26:13 PDT
Assigned to levin for landing.
David Levin
Comment 13 2009-06-22 14:03:39 PDT
Committed as http://trac.webkit.org/changeset/44953
Note You need to log in before you can comment on or make changes to this bug.