Bug 26552

Summary: JS bindings for HTMLAudioElement
Product: WebKit Reporter: Kyle Prete <kylep>
Component: PlatformAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
change to V8CustomBinding.h
none
new file necessary
dglazkov: review-
Patch
dglazkov: review-
Patch
dglazkov: review-
Patch
dglazkov: review-
Patch dglazkov: review+

Description Kyle Prete 2009-06-19 11:26:50 PDT 
WebKit/WebCore/bindings/v8/custom/V8CustomBinding.h needs DECLARE_CALLBACK(HTMLAudioElementConstructor);

WebKit/WebCore/bindings/v8/custom/ needs a .cpp file for V8HTMLAudioElementConstructor
Comment 1 Kyle Prete 2009-06-19 11:31:59 PDT 
Created attachment 31551 [details]
change to V8CustomBinding.h
Comment 2 Kyle Prete 2009-06-19 11:32:35 PDT 
Created attachment 31552 [details]
new file necessary
Comment 3 Dimitri Glazkov (Google) 2009-06-19 11:35:16 PDT 
Please read http://webkit.org/coding/contributing.html for guidelines on submitting patches.
Comment 4 Kyle Prete 2009-06-19 11:38:50 PDT 
Created attachment 31553 [details]
Patch
Comment 5 Dimitri Glazkov (Google) 2009-06-19 11:43:09 PDT 
Comment on attachment 31553 [details]
Patch

Need a ChangeLog entry.

> +    if (args.Length() > 0) {
> +        audio->setSrc(toWebCoreString(args[0]));
> +    }

No braces for one-liners.
Comment 6 Kyle Prete 2009-06-19 11:46:23 PDT 
Created attachment 31554 [details]
Patch
Comment 7 Dimitri Glazkov (Google) 2009-06-19 11:48:33 PDT 
Comment on attachment 31554 [details]
Patch

Don't rush :) Still need a ChangeLog entry.
Comment 8 Kyle Prete 2009-06-19 11:56:28 PDT 
Created attachment 31556 [details]
Patch

My bad. Didn't understand what you meant.
Comment 9 Dimitri Glazkov (Google) 2009-06-19 14:16:19 PDT 
Comment on attachment 31556 [details]
Patch

Sorry, spoke too soon -- need bug URL in ChangeLog.
Comment 10 Kyle Prete 2009-06-19 14:22:54 PDT 
Created attachment 31564 [details]
Patch
Comment 11 Dimitri Glazkov (Google) 2009-06-19 14:26:24 PDT 
Comment on attachment 31564 [details]
Patch

Beautiful.
Comment 12 David Levin 2009-06-22 13:26:13 PDT 
Assigned to levin for landing.
Comment 13 David Levin 2009-06-22 14:03:39 PDT 
Committed as http://trac.webkit.org/changeset/44953