Bug 265427
| Summary: | [WebRTC] Release assertion in webrtc::RtpPacketizerH264::PacketizeSingleNalu on bad input | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebRTC | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=265043 https://bugs.webkit.org/show_bug.cgi?id=265422 |
||
| Bug Depends on: | |||
| Bug Blocks: | 267906 | ||
David Kilzer (:ddkilzer)
Release assertion in webrtc::RtpPacketizerH264::PacketizeSingleNalu on bad input.
This release assertion fires when invalid input is passed in to `webrtc::RtpPacketizerH264::RtpPacketizerH264()` in `Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc`:
```
[...]
RTC_CHECK_GT(fragment.size(), 0u);
packets_.push(PacketUnit(fragment, true /* first */, true /* last */,
false /* aggregated */, fragment[0]));
++num_packets_left_;
return true;
}
```
<rdar://118861718>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/20972
EWS
Committed 271216@main (5755e4b0e628): <https://commits.webkit.org/271216@main>
Reviewed commits have been landed. Closing PR #20972 and removing active labels.
David Kilzer (:ddkilzer)
Closing this as the bug was fixed a in different way.
David Kilzer (:ddkilzer)
(In reply to David Kilzer (:ddkilzer) from comment #3)
> Closing this as the bug was fixed a in different way.
Oops, wrong bug. Resolved/Fixed.