Summary: | Modify SunSpider and jsc test shell to add a parsing only test suite | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Treat <manyoso> | ||||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | ||||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Adam Treat
2009-06-19 07:49:35 PDT
Created attachment 31544 [details]
Add a new testsuite for parsing performance to SunSpider and jsc.cpp
Comment on attachment 31544 [details]
Add a new testsuite for parsing performance to SunSpider and jsc.cpp
This shouldn't add new commandline arguments to jsc unless they have general case value.
I would make the parser test be
parser.js:
checkSyntax("parser-test-sources.js")
Created attachment 31555 [details]
Cleaned up patch taking into account Oliver's comment
Created attachment 31558 [details]
Change the docs in the ChangeLog to reflect 'checkSyntax' addition
Comment on attachment 31558 [details]
Change the docs in the ChangeLog to reflect 'checkSyntax' addition
missing a new line at the end of a couple of the files, correct those and r=me
Landed with 44870. Created attachment 39847 [details] proposed patch The patch landed in http://trac.webkit.org/changeset/44870 works correctly, but if you run WebKitTools/Scripts/run-sunspider, it doesn't pass the --parse-only parameter to SunSpider/sunspider script. Comment on attachment 39847 [details]
proposed patch
Please file a new bug for this patch.
|