|Summary:||CSS sibling selector (~) does not work with :target pseudo class|
|Severity:||Normal||CC:||abarth, bdakin, bugs.webkit.org, commit-queue, eric, hyatt, jamesr, marcoos+bwo, sjhobson, webkit.review.bot, yael|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Teun 2009-06-19 05:28:02 PDT
A line of CSS that looks like this: div:target~#second Does not match a <div id="second"/> preceded by a <div id="first"/> with a document loaded with doc.html#first although the ~ and the :target do work separately.
Comment 1 Teun 2009-06-19 05:28:47 PDT
Created attachment 31543 [details] Testcase for the sibling and target css
Comment 2 Nathan Hammond 2009-08-25 11:28:05 PDT
Created attachment 38560 [details] A very detailed test case which provides testing directions for recreating the bug. I too just ran into this bug in the latest nightly (r47686) and have created a very detailed test case which provides testing directions for recreating the bug.
Comment 4 Nathan Hammond 2009-08-25 16:34:05 PDT
Created attachment 38575 [details] Updated test case to include a closely related scenario with the adjacent sibling combinator. This bug appears to affect both sibling combinators. I've updated the test case to show the related issue as well. I believe that both issues should be part of this bug and we should rename it.
Comment 6 Yael 2011-01-03 09:34:55 PST
Created attachment 77813 [details] Patch. Allow style recalculation for forward siblings of elements that have a forward positional rule. This will not change behavior or impact performance of pages that do not have forward positional riles.
Comment 7 Beth Dakin 2011-04-26 16:35:46 PDT
Comment on attachment 77813 [details] Patch. I was worried that this causes too much style-resolution, but I think it's okay.
Comment 9 WebKit Commit Bot 2011-04-28 20:34:53 PDT
The commit-queue encountered the following flaky tests while processing attachment 91592 [details]: http/tests/xmlhttprequest/failed-auth.html bug 51835 (author: firstname.lastname@example.org) The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2011-04-28 20:36:19 PDT
Comment on attachment 91592 [details] Patch Clearing flags on attachment: 91592 Committed r85296: <http://trac.webkit.org/changeset/85296>
Comment 11 WebKit Commit Bot 2011-04-28 20:36:26 PDT
All reviewed patches have been landed. Closing bug.
Comment 12 WebKit Review Bot 2011-04-28 20:53:06 PDT
http://trac.webkit.org/changeset/85296 might have broken Windows 7 Release (Tests)
Comment 13 WebKit Commit Bot 2011-04-28 21:07:21 PDT
The commit-queue encountered the following flaky tests while processing attachment 91592 [details]: http/tests/xmlhttprequest/basic-auth.html bug 51613 (authors: email@example.com and firstname.lastname@example.org) http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html bug 52016 (author: email@example.com) The commit-queue is continuing to process your patch.