Bug 265381

Summary: Web Inspector: CSS Grid Page Overlay support for masonry layout
Product: WebKit Reporter: Razvan Caliman <rcaliman>
Component: Web InspectorAssignee: Razvan Caliman <rcaliman>
Status: RESOLVED FIXED    
Severity: Normal CC: inspector-bugzilla-changes, ntim, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 265382, 265383    
Attachments:
Description Flags
Screenshot of issue
none
Screenshot with patch applied
none
Test case for masonry + writing modes none

Razvan Caliman
Reported 2023-11-27 07:51:14 PST
The CSS Grid Page Overlay should correctly represent lines in a masonry layout. The CSS Grid Page Overlay is currently broken because it relies on there being grid tracks on both axes (see screenshot). Technically, there are no grid tracks in the masonry axis. Grid cells vary in dimension in the masonry axis. The masonry layout implementation is currently behind a flag ("CSS Masonry Layout") in Safari > Settings > Feature Flags.
Attachments
Screenshot of issue (1.61 MB, image/png)
2023-11-27 07:52 PST, Razvan Caliman 		no flags
Details
Screenshot with patch applied (1.64 MB, image/png)
2023-11-27 08:22 PST, Razvan Caliman 		no flags
Details
Test case for masonry + writing modes (4.89 KB, text/html)
2023-11-27 08:22 PST, Razvan Caliman 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Razvan Caliman
Comment 1 2023-11-27 07:52:19 PST
Created attachment 468766 [details] Screenshot of issue
Razvan Caliman
Comment 2 2023-11-27 07:52:58 PST Comment hidden (obsolete)
Radar WebKit Bug Importer
Comment 3 2023-11-27 07:53:16 PST Comment hidden (obsolete)
Tim Nguyen (:ntim)
Comment 4 2023-11-27 08:08:55 PST
rdar://117505876
Razvan Caliman
Comment 5 2023-11-27 08:21:34 PST
Pull request: https://github.com/WebKit/WebKit/pull/20934
Razvan Caliman
Comment 6 2023-11-27 08:22:22 PST
Created attachment 468767 [details] Screenshot with patch applied
Razvan Caliman
Comment 7 2023-11-27 08:22:55 PST
Created attachment 468768 [details] Test case for masonry + writing modes
EWS
Comment 8 2023-11-30 04:07:23 PST
Committed 271332@main (9a3f6dd4c6a6): <https://commits.webkit.org/271332@main> Reviewed commits have been landed. Closing PR #20934 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.