Bug 26531

Summary: Timezone calculation incorrect in Venezuela.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
The patch ggaren: review+

Gavin Barraclough
Reported 2009-06-18 21:56:53 PDT
The problem is that we're calculating the timezone relative to 01/01/2000, but the VET timezone changed from -4 hours to -4:30 hours on 12/09/2007. According to the spec, section 15.9.1.9 states "the time since the beginning of the year", presumably meaning the *current* year. Change the calculation to be based on whatever the current year is, rather than a canned date.
Attachments
The patch (2.14 KB, patch)
2009-06-18 21:58 PDT, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2009-06-18 21:58:48 PDT
Created attachment 31532 [details] The patch
Geoffrey Garen
Comment 2 2009-06-18 22:02:48 PDT
Comment on attachment 31532 [details] The patch r=me assuming all JSC tests pass
Gavin Barraclough
Comment 3 2009-06-18 22:07:24 PDT
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/wtf/DateMath.cpp Transmitting file data .. Committed revision 44842.
Note You need to log in before you can comment on or make changes to this bug.