Bug 265166

Summary: [IFC] Pre-compute "content has strong directionality character" bit
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq]Patch none

Description zalan 2023-11-20 17:09:53 PST
ssia
Comment 1 zalan 2023-11-20 17:58:15 PST
Created attachment 468695 [details]
Patch
Comment 2 Antti Koivisto 2023-11-21 06:02:23 PST
Comment on attachment 468695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468695&action=review

> Source/WebCore/layout/layouttree/LayoutInlineTextBox.cpp:37
> +InlineTextBox::InlineTextBox(String content, bool isCombined, WTF::OptionSet<ContentCharacteristic> contentCharacteristicSet, RenderStyle&& style, std::unique_ptr<RenderStyle>&& firstLineStyle)

no need to say WTF::

> Source/WebCore/layout/layouttree/LayoutInlineTextBox.h:45
> +    InlineTextBox(String, bool isCombined, WTF::OptionSet<ContentCharacteristic>, RenderStyle&&, std::unique_ptr<RenderStyle>&& firstLineStyle = nullptr);

(anywhere)
Comment 3 zalan 2023-11-21 06:17:36 PST
Created attachment 468709 [details]
[fast-cq]Patch
Comment 4 EWS 2023-11-21 07:14:36 PST
Committed 271016@main (dc839aa94c04): <https://commits.webkit.org/271016@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468709 [details].
Comment 5 Radar WebKit Bug Importer 2023-11-21 07:15:15 PST
<rdar://problem/118687678>