Summary: | AX: Cache AccessibilityText eagerly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joshua Hoffman <jhoffman23> | ||||
Component: | Accessibility | Assignee: | Joshua Hoffman <jhoffman23> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, samuel_white, tyler_w, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joshua Hoffman
2023-11-17 11:37:44 PST
Created attachment 468654 [details]
Patch
Comment on attachment 468654 [details]
Patch
Do you think this test is related?
TestWebKitAPI.AccessibilityTests.WebProcessLoaderBundleLoaded
/Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:170Value of: bundleLoaded Actual: falseExpected: true/Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:174Value of: [loadedPath hasSuffix:@"/System/Library/AccessibilityBundles/WebProcessLoader.axbundle"] Actual: falseExpected: true
Comment on attachment 468654 [details]
Patch
Do you think this test is related?
TestWebKitAPI.AccessibilityTests.WebProcessLoaderBundleLoaded
/Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:170Value of: bundleLoaded Actual: falseExpected: true/Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:174Value of: [loadedPath hasSuffix:@"/System/Library/AccessibilityBundles/WebProcessLoader.axbundle"] Actual: falseExpected: true
(In reply to chris fleizach from comment #4) > Comment on attachment 468654 [details] > Patch > > Do you think this test is related? > > TestWebKitAPI.AccessibilityTests.WebProcessLoaderBundleLoaded > > /Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/ > Tests/ios/AccessibilityTestsIOS.mm:170Value of: bundleLoaded Actual: > falseExpected: > true/Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/ > TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:174Value of: [loadedPath > hasSuffix:@"/System/Library/AccessibilityBundles/WebProcessLoader.axbundle"] > Actual: falseExpected: true I wouldn’t think it’s related since this patch only touches the isolated tree and this is an iOS failure. Committed 271161@main (1cf46fbe9b7b): <https://commits.webkit.org/271161@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468654 [details]. |