Bug 26499

Summary: Support hardware acceleration of <video>
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, eric.carlson
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Step 1 patch
darin: review+
Step 2: hook up the MediaPlayer with the layer compositing system hyatt: review+

Simon Fraser (smfr)
Reported 2009-06-17 16:37:24 PDT
We should support hardware acceleration of <video> presentation, when ACCELERATED_COMPOSITING is enabled.
Attachments
Step 1 patch (12.35 KB, patch)
2009-06-17 16:57 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
Step 2: hook up the MediaPlayer with the layer compositing system (32.04 KB, patch)
2009-06-17 18:41 PDT, Simon Fraser (smfr) 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2009-06-17 16:57:20 PDT
Created attachment 31468 [details] Step 1 patch
Simon Fraser (smfr)
Comment 2 2009-06-17 17:37:26 PDT
<rdar://problem/6978729>
Darin Adler
Comment 3 2009-06-17 17:53:42 PDT
Comment on attachment 31468 [details] Step 1 patch > + virtual bool requiresLayer() const { return true; } > + virtual bool isVideo() const { return true; } These should be private. For example, if anyone calls isVideo() on a RenderVideo you want the compile to fail so they don't create unneeded dead code. Of course, most of the other virtual functions should be private too for the same reason. Are those extra virtual calls in isSelfPaintingLayer() getting out of hand? r=me
Simon Fraser (smfr)
Comment 4 2009-06-17 18:41:49 PDT
Created attachment 31481 [details] Step 2: hook up the MediaPlayer with the layer compositing system
Simon Fraser (smfr)
Comment 5 2009-06-17 18:50:33 PDT
Comment on attachment 31468 [details] Step 1 patch Committed in http://trac.webkit.org/changeset/44794
Dave Hyatt
Comment 6 2009-06-18 11:12:20 PDT
Comment on attachment 31481 [details] Step 2: hook up the MediaPlayer with the layer compositing system r=me, make sure the VIDEO ifdefs are properly around everything.
Simon Fraser (smfr)
Comment 7 2009-06-18 11:53:03 PDT
http://trac.webkit.org/changeset/44809
Note You need to log in before you can comment on or make changes to this bug.