|Summary:||REGRESSION (r44758): First tab always uses Mac-style form controls|
|Product:||WebKit||Reporter:||Adam Roben (:aroben) <aroben>|
|Component:||Layout and Rendering||Assignee:||Adam Roben (:aroben) <aroben>|
|Severity:||Normal||Keywords:||InRadar, PlatformOnly, Regression|
|Version:||528+ (Nightly build)|
Description Adam Roben (:aroben) 2009-06-17 14:35:20 PDT
Comment 1 Adam Roben (:aroben) 2009-06-17 14:36:14 PDT
Comment 2 Adam Roben (:aroben) 2009-06-17 14:37:47 PDT
The problem is that RenderTheme::themeForPage is getting called before WebPreferences has communicated its settings to WebCore::Settings. RenderTheme::themeForPage consults Settings to decide whether it should return the RenderThemeWin or RenderThemeSafari instance, but Settings hasn't been initialized yet.
Comment 3 Adam Roben (:aroben) 2009-06-17 14:45:47 PDT
Created attachment 31441 [details] patch v1 + ChangeLog
Comment 4 Darin Adler 2009-06-17 14:49:46 PDT
Comment on attachment 31441 [details] patch v1 + ChangeLog r=me I'm sad we have to work around this instead of fixing it. Too bad we didn't realize this was wrong before landing the per-page theme change!
Comment 5 Dave Hyatt 2009-06-17 14:51:50 PDT
Comment on attachment 31441 [details] patch v1 + ChangeLog r=me