Bug 26489

Summary: Web Inspector: Typo in DatabaseQuery Error Message
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Spelling corrections
eric: review-
ChangeLog + Typo Fix jmalonzo: review+

Joseph Pecoraro
Reported 2009-06-17 11:49:04 PDT
In the "Databases" Tab of the Web Inspector, in the Database Console for a particular Database, executing a query resulting in an error produces the following error message: "An unexpected error 0 occured." "occured" is a typo, it should be "occurred" I'm not too familiar with how these messages work. I found: WebCore/inspector/front-end/DatabaseQueryView.js line 160: var message = WebInspector.UIString("An unexpected error %s occured.", error.code); However those UIString gets a value from localizedStrings which I believe comes from: WebCore/English.lproj/localizedStrings.js line 36: localizedStrings["An unexpected error %s occured."] = "An unexpected error %s occured."; I'm guessing all 3 places should be changed, but are there any other places that would need to be changed?
Attachments
Spelling corrections (27.55 KB, patch)
2009-06-17 11:58 PDT, Joseph Pecoraro
eric: review-
ChangeLog + Typo Fix (28.24 KB, patch)
2009-06-24 19:46 PDT, Joseph Pecoraro
jmalonzo: review+
Joseph Pecoraro
Comment 1 2009-06-17 11:58:19 PDT
Created attachment 31429 [details] Spelling corrections First timer here, so hopefully I did it right. It must think that English.lproj was a binary.
Eric Seidel (no email)
Comment 2 2009-06-24 18:57:13 PDT
Comment on attachment 31429 [details] Spelling corrections This change needs a ChangeLog. See http://webkit.org/coding/contributing.html Most notably: http://webkit.org/coding/contributing.html#changelogs
Joseph Pecoraro
Comment 3 2009-06-24 19:46:23 PDT
Created attachment 31829 [details] ChangeLog + Typo Fix Ran a prepare-ChangeLog this time!
Jan Alonzo
Comment 4 2009-06-25 04:47:44 PDT
Comment on attachment 31829 [details] ChangeLog + Typo Fix r=me.
Jan Alonzo
Comment 5 2009-06-25 05:42:57 PDT
(In reply to comment #4) > (From update of attachment 31829 [details] [review]) > r=me. > Landed in r45173.
Note You need to log in before you can comment on or make changes to this bug.