Bug 264859
| Summary: | Replace strongThis by protectedThis | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | WebCore Misc. | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, fujii.hironori, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jean-Yves Avenard [:jya]
From webkit coding style:
https://webkit.org/code-style-guidelines/#names-protectors-this
"Ref and RefPtr objects meant to protect this from deletion should be named "protectedThis".
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/118434279>
Fujii Hironori
Chris said we should update the style guideline in favor of the smart pointer guideline.
> we can get rid of protectedThis from our codebase
https://github.com/WebKit/WebKit/wiki/Smart-Pointer-Usage-Guidelines
Chris Dumez
(In reply to Fujii Hironori from comment #2)
> Chris said we should update the style guideline in favor of the smart
> pointer guideline.
>
> > we can get rid of protectedThis from our codebase
>
> https://github.com/WebKit/WebKit/wiki/Smart-Pointer-Usage-Guidelines
Not in lambda captures, which I think is what Jean-Yves is talking about.
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/20520
EWS
Committed 270757@main (c72b2982933d): <https://commits.webkit.org/270757@main>
Reviewed commits have been landed. Closing PR #20520 and removing active labels.