Bug 264808
| Summary: | [CMake] build-webkit script should check env var BUILD_WEBKIT_ARGS when checking if the cache should be cleaned | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cgarcia, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Alberto Lopez Perez
The script build-webkit caches the parameters passed to it in order to clean the CMake cache if the developer changes those from one invocation to the next one.
The issue is that we support passing parameters also via the environment variable BUILD_WEBKIT_ARGS (which we use on the bots)
But we are not checking the values from this env var when deciding to clean the cache or not.
So it happens that if you change this environment variable with new values the CMake cache will not be clean automatically.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/20477
EWS
Committed 271085@main (183e4e8088af): <https://commits.webkit.org/271085@main>
Reviewed commits have been landed. Closing PR #20477 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/118752244>