Bug 264766
| Summary: | wasm-omg test mode in stress tests should tier up to OMG immediately | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Asumu Takikawa <asumu> |
| Component: | WebAssembly | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Asumu Takikawa
Currently the wasm-omg test mode for stress tests does not tier up to OMG immediately.
For example, the following `run-jsc-stress-tests --debug --filter i31.js` *should* find an assertion failure in B3 that I found manually.
(the manual test run for comparison: `run-jsc --jsc-only --debug --useWebAssemblyGC=true --useWebAssemblyTypedFunctionReferences=true --useOMGJIT=true --useBBQJIT=false --thresholdForOMGOptimizeSoon=0 --thresholdForOMGOptimizeAfterWarmup=0 -m i31.js` while in `JSTests/wasm/gc`)
The run-jsc-stress-tests script needs some flags that will trigger an immediate tier-up. Possibly --thresholdForOMGOptimizeSoon=0 --thresholdForOMGOptimizeAfterWarmup=0 could work.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Asumu Takikawa
Pull request: https://github.com/WebKit/WebKit/pull/20438
EWS
Committed 270685@main (e7f7e511899e): <https://commits.webkit.org/270685@main>
Reviewed commits have been landed. Closing PR #20438 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/118372154>