Bug 264687
| Summary: | Sync 'RTCEncodedVideoFrame' and 'RTCEncodedAudioFrame' with WebIDL Specification | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | WebRTC | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While looking into IDLHarness failures on WPT, I noticed that we are failing a bunch of tests related to 'RTCEncodedVideoFrame' and 'RTCEncodedAudioFrame' and noticed that we are not exposing them to 'Window'.
Web-Spec (for Video): https://www.w3.org/TR/webrtc-encoded-transform/#RTCEncodedVideoFrame-interface & https://www.w3.org/TR/webrtc-encoded-transform/#RTCEncodedVideoFrameMetadata
and change to 'Exposed=(Window,DedicatedWorker)'
Web-Spec (for Audio): https://www.w3.org/TR/webrtc-encoded-transform/#RTCEncodedAudioFrame-interface & https://www.w3.org/TR/webrtc-encoded-transform/#RTCEncodedAudioFrameMetadata
and change to 'Exposed=(Window,DedicatedWorker)'
___
It leads to 19 tests passes in following WPT test case:
Test Case: https://wpt.fyi/results/webrtc-encoded-transform/idlharness.https.window.html?label=master&label=experimental&aligned=
Test Case Live Link: https://wpt.live/webrtc-encoded-transform/idlharness.https.window.html
___
Just wanted to raise so we can fix it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
We need to import 'webrtc-encoded-transform' tests from WPT before doing this because we don't have 'idlharness' test in our test suite.
Radar WebKit Bug Importer
<rdar://problem/118607685>
EWS
Committed 280198@main (b6d3b63a9d78): <https://commits.webkit.org/280198@main>
Reviewed commits have been landed. Closing PR #29981 and removing active labels.