Bug 26427

Summary: Use consistent Windows GUID Comparison Functions
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Use IsEqualGUID darin: review+

Brent Fulgham
Reported 2009-06-15 21:20:28 PDT
There are a handful of places where GUIDs are being compared using standard equality operator. These should be changed to the SDK IsEqualGUID call.
Attachments
Use IsEqualGUID (2.20 KB, patch)
2009-06-15 21:25 PDT, Brent Fulgham 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2009-06-15 21:25:50 PDT
Created attachment 31331 [details] Use IsEqualGUID
Darin Adler
Comment 2 2009-06-15 23:04:26 PDT
Comment on attachment 31331 [details] Use IsEqualGUID > - if (IID_IUnknown==riid || IID_IDataObject==riid) > + if (IsEqualIID(riid, IID_IUnknown) || > + IsEqualIID(riid, IID_IDataObject)) { > *ppvObject=this; > + } I don't think you needed to break this into multiple lines. And when you did, I wish you had followed the WebKit coding style (see the Indentation section, item 6, and the Braces section, item 3). r=me
Brent Fulgham
Comment 3 2009-06-16 09:44:57 PDT
Fixed line break and braces while landing. Landed in http://trac.webkit.org/changeset/44723
Note You need to log in before you can comment on or make changes to this bug.