Bug 264241
| Summary: | Remove namespace std overloads of isnan, isinf, and infinite for WTF time types | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Gerald Squelart <g_squelart> |
| Component: | Web Template Framework | Assignee: | Gerald Squelart <g_squelart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Gerald Squelart
Time types under WTF (MonotonicTime, etc.) add overloads of std::isnan, isinf, and isfinite, but it is generally UB to add declarations&definitions to `namespace std`: https://en.cppreference.com/w/cpp/language/extending_std
Instead, these functions should be class member functions, or free functions outside of `std`.
I don't believe these functions are used in generic code, so I think member functions are more appropriate here.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/117986797>
Gerald Squelart
Pull request: https://github.com/WebKit/WebKit/pull/20026
EWS
Committed 270366@main (acfb618b4d5a): <https://commits.webkit.org/270366@main>
Reviewed commits have been landed. Closing PR #20026 and removing active labels.