Bug 26423

Summary:

Expanding profile call stacks broken after sorting

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector (Deprecated)

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Major

CC:

aroben, jberlin, kmccullough, timothy, tolmasky

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

http://webkit.org/misc/drosera/

Attachments:

Description	Flags
Tell collapsed grid nodes with children to refresh the children on the next expand	timothy: review+

Timothy Hatcher

Reported 2009-06-15 16:12:56 PDT

Sometimes expanding a call stack will not show any decendants. Steps: 1) Load http://webkit.org/misc/drosera/ 2) Enable profiling in the Inspector. 3) Click "Nested functions" button. 4) View the profile. 5) Expand then colapse the "rot" call. 6) Sort by Calls. 7) Try to expand the same "rot" call. Results: Disclosure triangle expands but no decendancts show up. Expected: The decendancts should show up in the rows below. This might be a bug in DataGrid.js.

Attachments
Tell collapsed grid nodes with children to refresh the children on the next expand (1.63 KB, patch) 2009-09-24 18:34 PDT, Jessie Berlin	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jessie Berlin

Comment 1 2009-09-24 18:34:25 PDT

Created attachment 40096 [details] Tell collapsed grid nodes with children to refresh the children on the next expand

Timothy Hatcher

Comment 2 2009-09-24 18:40:26 PDT

Comment on attachment 40096 [details] Tell collapsed grid nodes with children to refresh the children on the next expand Nice! (You have tabs in your ChangeLog.)

Jessie Berlin

Comment 3 2009-09-24 19:21:05 PDT

Thanks! Removed the tabs and committed: http://trac.webkit.org/changeset/48742

Note You need to log in before you can comment on or make changes to this bug.