Bug 263905
| Summary: | build-webkit --minimal option has bitrotted | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Philip Chimento <philip.chimento> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Philip Chimento
I tried building a recent checkout with `build-webkit --gtk --minimal --notifications --service-worker`, and encountered a bunch of compile and link errors due to missing preprocessor guards, or headers needed in one file that were pulled in through another file behind a preprocessor guard. I've prepared a PR with fixes for these errors, that should get --minimal close to working again, at least for the GTK port.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Philip Chimento
Pull request: https://github.com/WebKit/WebKit/pull/19732
EWS
Committed 270103@main (cfc4a23cc201): <https://commits.webkit.org/270103@main>
Reviewed commits have been landed. Closing PR #19732 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/117837817>