Bug 263775

Summary:	[Nicosia] Simplify NicosiaPlatformLayer
Product:	WebKit	Reporter:	Carlos Garcia Campos <cgarcia>
Component:	Platform	Assignee:	Carlos Garcia Campos <cgarcia>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Carlos Garcia Campos

Reported 2023-10-27 06:07:08 PDT

We currently have generic classes that are created with a factory that creates the actual implementation. We only have one implementation, so we can just remove the unnecessary abstraction to save heap allocations, avoid casts and make the code easier to read.

Attachments
Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2023-10-27 06:14:23 PDT

Pull request: https://github.com/WebKit/WebKit/pull/19637

EWS

Comment 2 2023-10-30 23:00:02 PDT

Committed 269998@main (ee8fbcb55b4a): <https://commits.webkit.org/269998@main> Reviewed commits have been landed. Closing PR #19637 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2023-10-30 23:01:15 PDT

<rdar://problem/117722993>

Note You need to log in before you can comment on or make changes to this bug.