Bug 263578
| Summary: | Rename webrtc::pixelBufferFrom* functions to have 'create' in the name and fix a CVPixelBufferRef leak | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Media | Assignee: | Simon Fraser (smfr) <simon.fraser> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | simon.fraser, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
These functions return retained values, so should have 'create' in the name:
CVPixelBufferRef pixelBufferFromI420Buffer(const uint8_t* buffer, size_t length, size_t width, size_t height, I420BufferLayout) CF_RETURNS_RETAINED;
CVPixelBufferRef pixelBufferFromI420ABuffer(const uint8_t* buffer, size_t length, size_t width, size_t height, I420ABufferLayout) CF_RETURNS_RETAINED;
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/117388614>
Simon Fraser (smfr)
Pull request: https://github.com/WebKit/WebKit/pull/19471
EWS
Committed 269747@main (11a2ba1a7a1c): <https://commits.webkit.org/269747@main>
Reviewed commits have been landed. Closing PR #19471 and removing active labels.