Bug 263497
| Summary: | Assess and remove libxml2 hacks called 'hackAroundLibXMLEntityBug' and 'hackAroundLibXMLEntityParsingBug' | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | XML | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ddkilzer, don.olmstead, fujii.hironori, mcatanzaro, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
These hacks were added long time back and I think all WebKit embedder ports and dependencies would be updated and we might not need these hacks anymore:
They were removed from Blink in 2013:
Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=149452
&
Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=149412
___
Just wanted to raise so we can explore and delete them. This is just clean-up proposal in code.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
@Fuji, @Don & @Michael - Any comments from your side on GTK, WPE and Win-Cairo port?
Michael Catanzaro
Go ahead and remove them. Surely none of us still care about libxml from 2009.
David Kilzer (:ddkilzer)
Yes, it's fine to remove them.
EWS
Committed 269666@main (2b4d9ac4ad72): <https://commits.webkit.org/269666@main>
Reviewed commits have been landed. Closing PR #19397 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/117371488>