Bug 263448
| Summary: | Build fix: add gtest dependency to gmock project | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 263225 | ||
| Bug Blocks: | |||
David Kilzer (:ddkilzer)
Build fix: add gtest dependency to gmock project.
The gmock project depends on headers from the gtest project, but Xcode is not aware of this dependency, so gmock can sometimes build before gtest, resulting in a build failure:
```
In file included from OpenSource/Source/ThirdParty/gmock/src/gmock-all.cc:39:
In file included from include/gmock/gmock.h:59:
In file included from include/gmock/gmock-actions.h:145:
In file included from include/gmock/internal/gmock-internal-utils.h:46:
include/gmock/internal/gmock-port.h:56:10: fatal error: 'gtest/internal/gtest-port.h' file not found
#include <gtest/internal/gtest-port.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/gmock/internal/gmock-port.h:56:10: note: did not find header 'internal/gtest-port.h' in framework 'gtest' (loaded from 'OpenSource/WebKitBuild/Release')
1 error generated.
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/117266314>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/19347
EWS
Committed 269581@main (14adb9294c87): <https://commits.webkit.org/269581@main>
Reviewed commits have been landed. Closing PR #19347 and removing active labels.