Bug 26306

Summary:

DumpRenderTree crashes on Windows

Product:

WebKit

Reporter:

John Abd-El-Malek <jam>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, eric, mrowe, sfalken

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows Vista

Attachments:

Description	Flags
Added a patch	sfalken: review+

Description John Abd-El-Malek 2009-06-10 16:31:21 PDT

The problem is that CFURLCacheSharedURLCache isn't exported by the CoreNetwork.dll that comes with Safari 4.

Reverting 42565 fixes the issue.  Not sure if that's the long term solution, or the correct dll will be pushed out.

Comment 1 Eric Seidel (no email) 2009-06-10 16:41:37 PDT

http://trac.webkit.org/changeset/42565

Comment 2 John Abd-El-Malek 2009-06-10 16:41:41 PDT

Created attachment 31143 [details]
Added a patch

Not sure if the source should be updated, or whether there's a version of the DLLs coming out soon that's compatible.  At the very least, others who're having this issue can apply this patch.

Comment 3 Steve Falkenburg 2009-06-11 10:31:51 PDT

Reverting that change seems fine for now, and will work both before and after we update the headers to CFNetwork used by the open source project.

Comment 4 Brent Fulgham 2009-06-11 11:20:19 PDT

Committed in @r44609.

Comment 5 John Abd-El-Malek 2009-06-11 11:23:09 PDT

Thanks for committing it for me.