Bug 263051

Summary: return a createCommaSeparated() in CSSPropertyBackgroundBlendMode
Product: WebKit Reporter: Karl Dubost <karlcow>
Component: CSSAssignee: Karl Dubost <karlcow>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 17   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=261552
https://bugs.webkit.org/show_bug.cgi?id=263115
Bug Depends on: 263104    
Bug Blocks:    
Attachments:
Description Flags
testcase none

Karl Dubost
Reported 2023-10-11 17:39:13 PDT
Created attachment 468182 [details] testcase Currently the CSSPropertyBackgroundBlendMode, returns a space separated list instead of comma separated list - return CSSValueList::createSpaceSeparated(WTFMove(list)); + return CSSValueList::createCommaSeparated(WTFMove(list)); Uploaded Simple Test by Simon Fraser. It should return: "normal, luminosity" and not "normal luminosity"
Attachments
testcase (850 bytes, text/html)
2023-10-11 17:39 PDT, Karl Dubost 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-10-11 17:39:50 PDT
<rdar://problem/116838342>
Karl Dubost
Comment 2 2023-10-11 17:51:20 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18971
Karl Dubost
Comment 4 2023-10-11 18:01:13 PDT
See Bug 261552 (and my new coming comment there) ;)
Ahmad Saleem
Comment 5 2023-10-11 18:02:32 PDT
(In reply to Karl Dubost from comment #4) > See Bug 261552 (and my new coming comment there) ;) Sweet!! :-)
Karl Dubost
Comment 6 2023-10-11 19:42:30 PDT
Note tests will be fixed/extended in https://github.com/web-platform-tests/wpt/issues/42496
EWS
Comment 7 2023-10-13 15:47:51 PDT
Committed 269325@main (c7bdf3966172): <https://commits.webkit.org/269325@main> Reviewed commits have been landed. Closing PR #18971 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.