Bug 26296

Summary: REGRESSION: can't type in un-disabled textarea
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, hyatt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Fix collapsing empty shadow nodes in textareas.
none
Fix collapsing empty shadow nodes in textareas. eric: review+

Ojan Vafai
Reported 2009-06-10 12:13:43 PDT
Enabling a disabled, empty textarea leaves it untypeable. Patch + test coming soon.
Attachments
Fix collapsing empty shadow nodes in textareas. (3.70 KB, patch)
2009-06-10 12:22 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Fix collapsing empty shadow nodes in textareas. (3.81 KB, patch)
2009-06-10 12:31 PDT, Ojan Vafai 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2009-06-10 12:22:36 PDT
Created attachment 31137 [details] Fix collapsing empty shadow nodes in textareas.
Ojan Vafai
Comment 2 2009-06-10 12:28:08 PDT
Comment on attachment 31137 [details] Fix collapsing empty shadow nodes in textareas. Those expected results are bogus. Sorry about that. New patch coming in 1 min.
Ojan Vafai
Comment 3 2009-06-10 12:31:32 PDT
Created attachment 31138 [details] Fix collapsing empty shadow nodes in textareas.
Eric Seidel (no email)
Comment 4 2009-06-10 14:44:23 PDT
Comment on attachment 31138 [details] Fix collapsing empty shadow nodes in textareas. Looks sane to me. Test could be a js test, but this looks good too. :)
Ojan Vafai
Comment 5 2009-06-10 14:47:42 PDT
Yeah, I was going to write it as a JS test, but JS tests still don't deal properly with tests that use setTimeouts. Didn't seem worth the effort to fix now.
Ojan Vafai
Comment 6 2009-06-10 14:56:12 PDT
http://trac.webkit.org/changeset/44593
Note You need to log in before you can comment on or make changes to this bug.