Bug 26294

Summary: Uninitialized memory read copying ResourceResponse
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: PlatformAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 patch dglazkov: review+

Darin Fisher (:fishd, Google)
Reported 2009-06-10 09:47:14 PDT
Uninitialized memory read copying ResourceResponse http://build.chromium.org/buildbot/waterfall/builders/Webkit (purify)/builds/7557/steps/purify test: test_shell/logs/stdio This started failing somewhere between r44438 and r55455. Looking at ResourceResponseBase.cpp, it looks like m_lastModifiedDate is never initialized. This seems like a regression from r44453.
Attachments
v1 patch (2.11 KB, patch)
2009-06-10 10:10 PDT, Darin Fisher (:fishd, Google) 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2009-06-10 09:51:08 PDT
r44452 added a bunch of other member vars that are similarly uninitialized.
Darin Fisher (:fishd, Google)
Comment 2 2009-06-10 10:10:11 PDT
Created attachment 31134 [details] v1 patch
Dimitri Glazkov (Google)
Comment 3 2009-06-10 10:11:27 PDT
Comment on attachment 31134 [details] v1 patch Weee!
Eric Seidel (no email)
Comment 4 2009-06-12 15:47:45 PDT
Patch is not made from the root, so my fancy auto-commit script (bug 26283) can't handle it yet. :(
Adam Barth
Comment 5 2009-06-13 21:27:34 PDT
Will land.
Adam Barth
Comment 6 2009-06-13 21:42:54 PDT
This patch is already in the tree. Not sure what revision.
Note You need to log in before you can comment on or make changes to this bug.