Summary: | [Qt] build break in ImageDecoderQt.cpp. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yongjun Zhang <yongjun.zhang> | ||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | Keywords: | Qt | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Yongjun Zhang
2009-06-10 08:33:14 PDT
Created attachment 31131 [details]
quick patch to fix the build break.
Comment on attachment 31131 [details]
quick patch to fix the build break.
lgtm.
Created attachment 31162 [details]
set m_isSizeAvailable to false when failed, to keep it consistent.
Drive-by, since I wrote the new ImageDecoder.h code: Remove the setSize(-1, -1) call from reset(). You can't have the size become _less_ available on receiving _more_ data; either the size was not yet set and remains unset, or it was already set and can remain set. Remove "m_sizeAvailable = false;" from ImageDecoder.h. This is inappropriate. A modified patch, after Peter's comment, is landed in r44605 http://trac.webkit.org/changeset/44605 |