Bug 26291

Summary: [Qt] build break in ImageDecoderQt.cpp.
Product: WebKit Reporter: Yongjun Zhang <yongjun.zhang>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Qt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
quick patch to fix the build break.
eric: review+
set m_isSizeAvailable to false when failed, to keep it consistent. none

Yongjun Zhang
Reported 2009-06-10 08:33:14 PDT
ImageDecoder.h changes the visibility of m_size and m_isAvailable to private which breaks the compiling of ImageDecoderQt.cpp.
Attachments
quick patch to fix the build break. (2.14 KB, patch)
2009-06-10 08:40 PDT, Yongjun Zhang 		eric: review+
DetailsFormatted DiffDiff
set m_isSizeAvailable to false when failed, to keep it consistent. (2.79 KB, patch)
2009-06-11 08:02 PDT, Yongjun Zhang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yongjun Zhang
Comment 1 2009-06-10 08:40:30 PDT
Created attachment 31131 [details] quick patch to fix the build break.
Eric Seidel (no email)
Comment 2 2009-06-11 01:07:40 PDT
Comment on attachment 31131 [details] quick patch to fix the build break. lgtm.
Yongjun Zhang
Comment 3 2009-06-11 08:02:10 PDT
Created attachment 31162 [details] set m_isSizeAvailable to false when failed, to keep it consistent.
Peter Kasting
Comment 4 2009-06-11 10:15:24 PDT
Drive-by, since I wrote the new ImageDecoder.h code: Remove the setSize(-1, -1) call from reset(). You can't have the size become _less_ available on receiving _more_ data; either the size was not yet set and remains unset, or it was already set and can remain set. Remove "m_sizeAvailable = false;" from ImageDecoder.h. This is inappropriate.
Ariya Hidayat
Comment 5 2009-06-11 10:29:06 PDT
A modified patch, after Peter's comment, is landed in r44605 http://trac.webkit.org/changeset/44605
Note You need to log in before you can comment on or make changes to this bug.