Bug 262868

Summary:

AX: All methods in AXIsolatedObject should be final, not override

Product:

WebKit

Reporter:

Tyler Wilcock <tyler_w>

Component:

Accessibility

Assignee:

Tyler Wilcock <tyler_w>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Tyler Wilcock 2023-10-08 12:21:48 PDT

This can help de-virtualize function calls:

https://github.com/llvm/llvm-project/blob/876334321f842edadcc0cd4241c76b59bb888b9e/clang/lib/AST/DeclCXX.cpp#L2260#L2261

Comment 1 Radar WebKit Bug Importer 2023-10-08 12:21:56 PDT

<rdar://problem/116650535>

Comment 2 Tyler Wilcock 2023-10-08 12:27:25 PDT

Created attachment 468115 [details]
Patch

Comment 3 EWS 2023-10-08 16:37:54 PDT

Committed 269059@main (db4f2bb7df50): <https://commits.webkit.org/269059@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468115 [details].