Bug 262866
| Summary: | text-decoration-thickness should support percentages | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | CSS | Assignee: | ChangSeok Oh <changseok> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | changseok, fantasai.bugs, vitor.roriz, webkit-bug-importer |
| Priority: | P2 | Keywords: | GoodFirstBug, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tim Nguyen (:ntim)
This should be pretty simple to support given we already support ems.
Here are places that need changing:
https://searchfox.org/wubkat/rev/9709f5c78a15a0ae1e723096557a6a060822d868/Source/WebCore/css/CSSProperties.json#8301-8305
https://searchfox.org/wubkat/rev/9709f5c78a15a0ae1e723096557a6a060822d868/Source/WebCore/style/StyleBuilderConverter.h#881
https://searchfox.org/wubkat/rev/9709f5c78a15a0ae1e723096557a6a060822d868/Source/WebCore/rendering/style/TextDecorationThickness.h
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tim Nguyen (:ntim)
This should fix this WPT:
imported/w3c/web-platform-tests/css/css-fonts/size-adjust-text-decoration.tentative.html
ChangSeok Oh
I will take a look.
ChangSeok Oh
By the way, is the name of size-adjust-text-decoration.tentative.html a mistake? Its reference file name is size-adjust-text-decoration-tentative-ref.html. Yeah, I am talking about the dot just before "tentative".
ChangSeok Oh
Pull request: https://github.com/WebKit/WebKit/pull/19085
Radar WebKit Bug Importer
<rdar://problem/116985587>
ChangSeok Oh
*** Bug 255868 has been marked as a duplicate of this bug. ***
EWS
Committed 269886@main (4172b60326a8): <https://commits.webkit.org/269886@main>
Reviewed commits have been landed. Closing PR #19085 and removing active labels.