Bug 26284

Summary: LayoutTests\editing\deleting\4875189.html should be a dumpAsText test instead of a pixel test
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
This patch converts LayoutTests\editing\deleting\4875189.html to a dumpAsText test. eric: review+

Ryosuke Niwa
Reported 2009-06-09 17:32:50 PDT
LayoutTests\editing\deleting\4875189.html only tests whether the result consists of two paragraphs or not. It should be using a dumpAsText test instead.
Attachments
This patch converts LayoutTests\editing\deleting\4875189.html to a dumpAsText test. (5.38 KB, patch)
2009-06-11 11:35 PDT, Ryosuke Niwa 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2009-06-11 11:35:47 PDT
Created attachment 31169 [details] This patch converts LayoutTests\editing\deleting\4875189.html to a dumpAsText test.
Julie Parent
Comment 2 2009-06-11 12:04:15 PDT
Comment on attachment 31169 [details] This patch converts LayoutTests\editing\deleting\4875189.html to a dumpAsText test. > <p>This test deletes the contents of a list, then it performs another delete, which should remove the empty list item. There should be two paragraphs below.</p> > <div id="div" contentEditable="true">Paragraph One.<ul><li id="li">bar</li></ul>Paragraph Two.</div> > +<ol id="console"></ol> Why is the console a list?
Eric Seidel (no email)
Comment 3 2009-06-11 12:06:25 PDT
Comment on attachment 31169 [details] This patch converts LayoutTests\editing\deleting\4875189.html to a dumpAsText test. Looks fine.
Ryosuke Niwa
Comment 4 2009-06-11 13:36:26 PDT
>Why is the console a list? I'm not sure the original file had console as a list. Maybe it's to do with reproducing the error. It's maybe that making it div would affect the result. e.g. it only occurs when there is exactly one div, or when it's the last div item in the page.
Julie Parent
Comment 5 2009-06-11 18:02:54 PDT
Committed as http://trac.webkit.org/changeset/44621
Alexey Proskuryakov
Comment 6 2009-07-14 13:48:54 PDT
*** Bug 26225 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.