Bug 262300
| Summary: | Remove BBC radio player quirk leftovers | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Olivier Blin <olivier.blin> |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | achristensen, bfulgham, cdumez, katherine_cheney, pascoe, ross.kirsling, webkit-bug-importer, wilander |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=219949 https://bugs.webkit.org/show_bug.cgi?id=253338 https://bugs.webkit.org/show_bug.cgi?id=262533 |
||
Olivier Blin
The BBC radio player quirk has been removed in 266597@main (9b58b4bed53b), which is a back-merge of 259548.824@safari-7615-branch (cff01e3).
But this commit did not remove the Quirks::staticRadioPlayerURLString() method initially removed, and a second quirk part added in 261190@main (ae690092de53) which is now irrelevant and potentially broken.
This also breaks build without ITP support.
See also the restricted bug 257352.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Olivier Blin
Pull request: https://github.com/WebKit/WebKit/pull/18339
EWS
Committed 268769@main (e0366ad8cf40): <https://commits.webkit.org/268769@main>
Reviewed commits have been landed. Closing PR #18339 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/116397645>