Bug 26227

Summary: Upstream V8 bindings for V8CustomXpathNSResolver
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch dglazkov: review+

Nate Chapin
Reported 2009-06-05 14:16:56 PDT
See summary.
Attachments
patch (8.36 KB, patch)
2009-06-05 14:19 PDT, Nate Chapin 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2009-06-05 14:19:20 PDT
Created attachment 31011 [details] patch
Dimitri Glazkov (Google)
Comment 2 2009-06-05 14:42:52 PDT
Comment on attachment 31011 [details] patch > +// Copyright (c) 2008, Google Inc. (C) 2008 Google Inc. All rights reserved. :)
Adam Barth
Comment 3 2009-06-13 11:14:02 PDT
Will land.
Adam Barth
Comment 4 2009-06-13 14:28:28 PDT
Sending WebCore/ChangeLog Adding WebCore/bindings/v8/custom/V8CustomXPathNSResolver.cpp Adding WebCore/bindings/v8/custom/V8CustomXPathNSResolver.h Sending WebCore/bindings/v8/custom/V8DocumentCustom.cpp Transmitting file data .... Committed revision 44658.
Adam Barth
Comment 5 2009-06-13 15:01:44 PDT
Looks like you need to check in the downstream half of this change to fix the integration builder: http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20Mac%20(webkit.org)/builds/384/steps/compile/logs/stdio I can roll the upstream patch back if you like, but that seems counter productive.
Note You need to log in before you can comment on or make changes to this bug.