Summary: | Canvas initial lineWidth not in sync with graphics backends. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean McNamee <deanm> | ||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, eric, oliver | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Dean McNamee
2009-06-04 08:22:04 PDT
Created attachment 30947 [details]
patch w/ layout test
Comment on attachment 30947 [details]
patch w/ layout test
The fix itself looks good but i don't like the layout test. You should look at the design of the more modern canvas tests -- they're basically the same structure as JS ones so find a test which has the following
fast/canvas/test-name.html // html document will just have some boiler plate that includes a couple of js files, resoureces/test-name.js and then another js file
fast/canvas/resources/test-name.js // The actual test itself
I *think* the isPointInPath tests cases will be of this newer style. The newer style is vastly more useful as we use getImagedata to anaylse the result of drawing rather than relying on pixel comparisons. This is especially benefical given people typically do no run pixel tests, but also because it's much easier to see what is being tested.
--Oliver
Created attachment 31088 [details]
New patch with more modern layout test
Comment on attachment 31088 [details]
New patch with more modern layout test
r=me
Guys, this is missing expected test results. The buildbots are not happy. |