Bug 26177

Summary:

Add Chromium-specific constructors to Platform event classes.

Product:

WebKit

Reporter:

Dmitry Titov <dimich>

Component:

WebCore Misc.

Assignee:

Dmitry Titov <dimich>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, fishd

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	none

Dmitry Titov

Reported 2009-06-03 16:12:11 PDT

That fixes the build break caused by change of 'protected' data members to 'private' in PlatformMouseEvent and PlatformWheelEvent. Also it makes it possible to remove MakePlatformMouseEvent and MakePlatformWheelEvent in Chromium glue.

Attachments
Proposed patch (2.22 KB, patch) 2009-06-03 16:13 PDT, Dmitry Titov	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dmitry Titov

Comment 1 2009-06-03 16:13:48 PDT

Created attachment 30931 [details] Proposed patch

Dimitri Glazkov (Google)

Comment 2 2009-06-03 16:27:43 PDT

Let's just turn private back into protected here.

Sam Weinig

Comment 3 2009-06-03 16:45:40 PDT

It seems like a gratuitous layering violation to have WebKit level classes referenced from WebCore.

Dimitri Glazkov (Google)

Comment 4 2009-06-03 16:49:45 PDT

(In reply to comment #3) > It seems like a gratuitous layering violation to have WebKit level classes > referenced from WebCore. > yup.

Dmitry Titov

Comment 5 2009-06-03 16:58:16 PDT

Comment on attachment 30931 [details] Proposed patch Removing r? Yep, that is layering violation. Will just change 'private' back to 'protected'. The better solution can come from integrating Chromium glue into WebKit tree.

Dmitry Titov

Comment 6 2009-06-03 17:08:33 PDT

Change to 'protected' landed as a build fix: http://trac.webkit.org/changeset/44404

Note You need to log in before you can comment on or make changes to this bug.