Bug 26162

Summary: With accelerated compositing, interrupted compound transform transition jumps around
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: CSSAssignee: Chris Marrin <cmarrin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Test case
none
Patch
sam: review+
Patch with test simon.fraser: review+

Chris Marrin
Reported 2009-06-03 09:00:47 PDT
In the attached testcase, (with accelerated compositing enabled) a transition of a compound transform is interrupted. This causes the element to jump to an odd position. From rdar://problem/6612047
Attachments
Test case (1.27 KB, text/html)
2009-06-03 09:01 PDT, Chris Marrin 		no flags
Details
Patch (2.50 KB, patch)
2009-06-03 10:34 PDT, Chris Marrin 		sam: review+
DetailsFormatted DiffDiff
Patch with test (5.15 KB, patch)
2009-06-03 15:44 PDT, Chris Marrin 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2009-06-03 09:01:46 PDT
Created attachment 30908 [details] Test case
Chris Marrin
Comment 2 2009-06-03 10:34:31 PDT
Created attachment 30912 [details] Patch
Chris Marrin
Comment 3 2009-06-03 10:34:48 PDT
Added patch with the same fix as in the radar
Sam Weinig
Comment 4 2009-06-03 14:54:09 PDT
Comment on attachment 30912 [details] Patch > { > - // Do the cleanup here instead of in the base class so the specialized methods get called > + // // Make sure to tell the renderer that we are ending. This will make sure any accelerated animations are removed. Double comment! r=me.
Chris Marrin
Comment 5 2009-06-03 15:44:03 PDT
Created attachment 30927 [details] Patch with test This replacement patch includes a manual test. Because of the nature of the animation bug, there's no way to make a meaningful layout test.
Simon Fraser (smfr)
Comment 6 2009-06-03 16:25:05 PDT
Comment on attachment 30927 [details] Patch with test > +<html lang="en"> > +<head> > + <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> > + <title>Value Function Bug?</title> Please fix the page title, and add a link to this bug. r=me
Chris Marrin
Comment 7 2009-06-03 16:58:17 PDT
Sending WebCore/ChangeLog Adding WebCore/manual-tests/interrupted-compound-transform.html Sending WebCore/page/animation/ImplicitAnimation.cpp Sending WebCore/page/animation/KeyframeAnimation.cpp Transmitting file data .... Committed revision 44403.
Note You need to log in before you can comment on or make changes to this bug.